Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment fixes #815

Merged
merged 3 commits into from
Feb 9, 2023
Merged

Alignment fixes #815

merged 3 commits into from
Feb 9, 2023

Conversation

fbacall
Copy link
Member

@fbacall fbacall commented Feb 9, 2023

Summary of changes

  • Reverts a hack to Bootstrap's row class that was causing alignment issues.
  • Fixes abuse of the row class to vertically space elements.
  • Tweaks some other CSS for alignment purposes.

Motivation and context

#813

Screenshots

Before:
image

After:
image

Checklist

  • I have read and followed the CONTRIBUTING guide.
  • I confirm that I have the authority necessary to make this contribution on behalf of its copyright owner and agree
    to license it to the TeSS codebase under the
    BSD license.

* It was not applying the negative margins so any `col-` divs inside the row would not be horizontally aligned with non-row content.
* It was being abused to apply vertical margins to various elements. Removed these, or replaced with helper class (e.g. `my-3`) to produce the same effect.
Also reduce padding between sort and filter in sidebar
@fbacall fbacall merged commit d1ed168 into tess-1.3 Feb 9, 2023
@fbacall fbacall deleted the fix-row-abuse branch February 9, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant