Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI feedback on 1.2.1 #813

Open
3 of 8 tasks
mihai-sysbio opened this issue Feb 8, 2023 · 1 comment
Open
3 of 8 tasks

UI feedback on 1.2.1 #813

mihai-sysbio opened this issue Feb 8, 2023 · 1 comment
Labels
feature request Requested by community. Decide on roadmap

Comments

@mihai-sysbio
Copy link

mihai-sysbio commented Feb 8, 2023

Is your feature request related to a problem? Please describe

This is feedback on the latest release 1.2.1 as shown on the public website.

Describe the solution you'd like

  • one thing I didn’t quite recognize is the shade of blue - is that consistent with the ELIXIR palette?
  • I’m not sure about having the breadcrumbs at the top left of the page. TeSS is not a complicated website, and it kind of overlaps in functionality (and proximity) with the navbar.
  • When the navbar links are active/hovered, perhaps one should highlight a rectangle around them as well, almost like a button. Right now it looks like a hyperlink, which is not really typical for navbars.
  • For the contact email, wouldn’t it be more professional to have an ELIXIR alias than [email protected]?
  • It would be nice if the version in the bottom would be a hyperlink to GH (but that’s confusing right now since the latest release there is 1.2.0 and the website shows 1.2.1
  • The ELIXIR logo top left looks as if it’s outside the left border of the page
  • The i button on the Events and Materials pages should be pulled to the right of the page a bit so it aligns vertically with the rest of the elements
  • The search bar in the Events and Materials pages should be pulled to the left a bit to align

Additional context

Please feel free to edit this issue and split it across several, so that it better aligns with the development work.

@mihai-sysbio mihai-sysbio added the feature request Requested by community. Decide on roadmap label Feb 8, 2023
@fbacall
Copy link
Member

fbacall commented Feb 9, 2023

one thing I didn’t quite recognize is the shade of blue - is that consistent with the ELIXIR palette?

I think so. Maybe @sitjart can comment.

I’m not sure about having the breadcrumbs at the top left of the page. TeSS is not a complicated website, and it kind of overlaps in functionality (and proximity) with the navbar.

I think I agree with this, although there are some pages where you can end up deeper in a page hierarchy (managing content provider sources, and other admin things). I'll bring it up at the next TeSS club to see what others think.

When the navbar links are active/hovered, perhaps one should highlight a rectangle around them as well, almost like a button. Right now it looks like a hyperlink, which is not really typical for navbars.
For the contact email, wouldn’t it be more professional to have an ELIXIR alias than [email protected]?

Yes, probably. At the time it was not possible to get an email address under the elixir domain, however this has recently been addressed, so I'll look into replacing it with [email protected] or something.

It would be nice if the version in the bottom would be a hyperlink to GH (but that’s confusing right now since the latest release there is 1.2.0 and the website shows 1.2.1

👍

actually 1.2.1 was not officially "released" yet, but it could link to the tag.

(also, confusingly, the UI redesign is actually part of the 1.3.0 release, but was was merged into 1.2.1 as part of a pre-release to show to our SAB...)

The ELIXIR logo top left looks as if it’s outside the left border of the page

The i button on the Events and Materials pages should be pulled to the right of the page a bit so it aligns vertically with the rest of the elements

The search bar in the Events and Materials pages should be pulled to the left a bit to align

Yeah, there are some padding tweaks that need doing. Various sub elements of the page (breadcrumbs, sidebar) have their own X padding in addition to the X padding of the page wrapper, whereas the things in the navbar don't. Also we have broken/abused one of the Bootstrap layout classes (row), which needs to be fixed.

fbacall added a commit that referenced this issue Feb 9, 2023
* It was not applying the negative margins so any `col-` divs inside the row would not be horizontally aligned with non-row content.
* It was being abused to apply vertical margins to various elements. Removed these, or replaced with helper class (e.g. `my-3`) to produce the same effect.
fbacall added a commit that referenced this issue Feb 9, 2023
Also reduce padding between sort and filter in sidebar
@fbacall fbacall mentioned this issue Feb 9, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requested by community. Decide on roadmap
Projects
None yet
Development

No branches or pull requests

2 participants