Add qto_link() function + minor refactor for qto_fig()
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add span family
Also style link.R w/ 4 space indents
|
Thanks -- I see you beat me to the vectorising of the class arg! I should have some time to look at this PR tomorrow. |
|
Thanks again for the PR @elipousson and apologies for the delay in getting to this -- the year rearing its ugly head. LGTM! |
ElianHugh
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caught a minor issue w/ the
check_src()helper function (I had forgotten to passxtocaller_arg()) and added aqto_link()function while I was at it.I also have some ideas for some expanding + cleaning up documentation but figured I should keep that in a separate pull request.