Route #13
Merged
Route #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterstadler
requested changes
May 15, 2024
src/components/OsdComponent.vue
Outdated
| @@ -182,18 +182,31 @@ export default { | |||
| // The users has selected an existing annotation | |||
| // console.log('selected annotation') | |||
| // console.log(annotation) | |||
| console.log("anno is clicked") | |||
| console.log("anno is clicked " , annotation) | |||
There was a problem hiding this comment.
are the changes to this file relevant?
There was a problem hiding this comment.
more or less the same as above: the changes here are irrelevant(?) for the PR, so please remove them.
In 2e41245 you only removed one change but not the all
| include "/GH_OAUTH_CLIENT.conf"; | ||
| # reverse proxy to github access_token | ||
| # set rule to /auth explicitly | ||
| location = /auth { |
There was a problem hiding this comment.
Don't we need the GitHub authentication?
There was a problem hiding this comment.
Nothing changed here in 2e41245?!
peterstadler
requested changes
May 15, 2024
Co-authored-by: Peter Stadler <[email protected]>
Co-authored-by: Peter Stadler <[email protected]>
peterstadler
requested changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add sub-path option for deployment