fix getPreference function #527
Merged
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the getPreference would only check the URL parameter and not the actual preferences for the key "application_language". This resulted in an always-English frontend independent of the preferences set in the prefs file Co-Authored-By: Daniel Röwenstrunk <[email protected]>
krHERO
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the getPreference would only check the URL parameter and not the actual preferences for the key "application_language". This resulted in an always-English frontend independent of the preferences set in the prefs file.
The issue was reported by @obertsalome and can be reproduced with the current Pintos data by simply starting the Edirom without any URL parameter. This will show the frontend GUI elements in English although the "application_language" is set to "de".
Types of changes
Overview