[Issue #984] fix lint issues, update golangci-lint and action versions #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
==========================================
+ Coverage 37.55% 37.63% +0.07%
==========================================
Files 46 46
Lines 3560 2976 -584
==========================================
- Hits 1337 1120 -217
+ Misses 2108 1737 -371
- Partials 115 119 +4 ☔ View full report in Codecov by Sentry. |
|
PLC4x building issue please refer to golang/go#68976 |
|
mssql with go 1.23.1 issue please refer to microsoft/mssql-docker#895 |
upgrade codecov action to v4, add token, disable failing error newline add in sleep for sqlserver let sqlserver run on host for test, fix small typo fix typo, fix sqlserver tag add SQL Server TrustServerCertificate option encryption disable for sqlserver remove encryption revert sqlserver image cleanup services before starting the next one in telemetryservice test remove other telemetry tests revert changes, put sql server test to the top add godebug to handle negative serialnumber tls by sqlserver docker image revert orders, use 1.22.7 for plc4x base image revert plc4x image
tomqin93
force-pushed
the
issue_984_golangci-lint-fix
branch
from
192a18c to
10d482b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes golangci lint failing issue in #984
Will this PR make the community happier?
Yes
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #984How is this PR tested
Special notes for your reviewer:
Release note: