Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color) - Add LVGL scroll bar where needed. #3268

Merged
merged 5 commits into from
Mar 24, 2023

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Feb 27, 2023

WIP - add scroll bars to views with more content than will fit on a single screen.

Part 1 - Radio Settings:

  • Tools
  • SD Card
  • Radio Setup
  • Themes
  • GLobal Functions
  • Hardware

@philmoz
Copy link
Collaborator Author

philmoz commented Feb 27, 2023

Part 2 - model and screen pages.

  • Model Setup
  • Preflight checks
  • Timers setup
  • Module setup
  • Inputs list
  • Inputs edit
  • Mixes list
  • Outputs list
  • Curves list
  • Curve edit
  • Logical switches list
  • Special functions list
  • Custom scripts list
  • Telemetry list
  • Telemetry sensor edit
  • Screen settings - main view
  • Screen settings - user interface

@JimB40
Copy link
Collaborator

JimB40 commented Feb 27, 2023

Styling: #3259
@philmoz on tight layouts packed from left to right screen's edges we have to test transparent scrollbar background.
To my test in Figma solid backround with color of scrolled area works better even it clips content.

but we may be forced in some cases to use transparent background (like in Model Browser aircrafts list)
Screenshot 2023-02-27 at 09 13 51

@JimB40
Copy link
Collaborator

JimB40 commented Feb 27, 2023

Definetely we need proper styling.
Current one doesn't work at all. Can you spot scrollbar?
screen-2023-02-27-092721

@raphaelcoeffic @gagarinlg you have best knowledge abt LVGL styling. Can you make kind of dev session with @philmoz to agree how to code LVGL styling.
Most of styling sheets are aready uploaded. Summary here #3220

I don't think we'll manage to do styling in 2.9 rather 2.10 but we should start.

@philmoz
Copy link
Collaborator Author

philmoz commented Feb 27, 2023

For popup lists and menus the required change is in the libopenui project (PR 85).
EdgeTX/libopenui#85

@philmoz philmoz force-pushed the scrollbars branch 3 times, most recently from 42b4d91 to c68296c Compare March 17, 2023 06:06
@pfeerick pfeerick self-assigned this Mar 22, 2023
@pfeerick pfeerick added enhancement ✨ New feature or request color Related generally to color LCD radios UX-UI Related to user experience (UX) or user interface (UI) behaviour labels Mar 22, 2023
@pfeerick pfeerick added this to the 2.9 milestone Mar 22, 2023
@pfeerick
Copy link
Member

pfeerick commented Mar 23, 2023

With a build of this PR (using current libopenui head commit) it seems like there is an issue with refreshing the list views properly after adding a new input or mix - the plus button ends up in the middle of the list. On switching tabs it is rebuilt correctly. SF and LS views are fine though.

image

And while it is not directly related to this PR, I noticed when testing it on the EL18 that there seems to be a double-up of the sensor names on the NV14/EL18 screen, and stays there even when there is sensor data.

image
image

@philmoz
Copy link
Collaborator Author

philmoz commented Mar 23, 2023

I've fixed the position problem with new entries on Inputs and Mixes.

I can't reproduce the telemetry problem on the NV14 in the simulator.

@pfeerick
Copy link
Member

This might help with reproducibility (got it to play up with main simu and a recent PR Simulator also):
model1.zip

However, since it's not related to this PR, that's a bug to squash later. Latest changes seems to be working fine.

@pfeerick pfeerick merged commit 8fc5a1c into EdgeTX:main Mar 24, 2023
@philmoz philmoz deleted the scrollbars branch October 9, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color Related generally to color LCD radios enhancement ✨ New feature or request UX-UI Related to user experience (UX) or user interface (UI) behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants