Char Stream Request - Optimized for high rate #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receive a stream of characters (ASCII), accumulate them and
provide the means to output them in an acceding sorted manner.
Limitations:
- Sorted based on the ASCII table, no special care has been done to handle upper and lower characters.
- It can accumulate between 2^(sizeof(int)) to 256 * (2^(sizeof(int))) characters.
Note: It is up to the application that uses this module to specify how many characters to recv
until a print is performed, followed by a clear to reset the data.
|
|
||
| CharStreamReq::CharStreamReq() | ||
| { | ||
| this->max_num_of_unique_chars = (unsigned char)~0 + 1; |
There was a problem hiding this comment.
This is constant, therefore can be a member of the class without the need to use new/delete in the const/destr.
There was a problem hiding this comment.
Use std::numeric_limits::max() instead of this trick.
(From #include )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receive a stream of characters (ASCII), accumulate them and
provide the means to output them in an acceding sorted manner.
Limitations:
Note: It is up to the application that uses this module to specify how many characters to recv
until a print is performed, followed by a clear to reset the data.