Skip to content

Commit

Permalink
Multiple asserts are only available since PHP 7.3
Browse files Browse the repository at this point in the history
This is unfortunately because multiple asserts are only fixed since
laminas-permissions-acl 2.9.0 and that version only support PHP 7.3.
So that forces us to not support PHP 7.2 for that specific features.
  • Loading branch information
PowerKiKi committed Dec 4, 2021
1 parent fdbda2c commit 796b7a6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ jobs:
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
restore-keys: ${{ runner.os }}-composer-

- name: Remove lock for PHP 8
if: matrix.php-version == '8.0'
- name: Remove lock for newer PHP
if: matrix.php-version != '7.2'
run: rm composer.lock && composer require symfony/cache

- name: Install dependencies
Expand Down Expand Up @@ -120,6 +120,9 @@ jobs:
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
restore-keys: ${{ runner.os }}-composer-

- name: Remove lock for newer PHP
run: rm composer.lock && composer require symfony/cache

- name: Install dependencies
run: composer install

Expand Down
3 changes: 3 additions & 0 deletions tests/Acl/AclTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ public function __construct()
self::assertSame('Non-logged user with role anonymous is not allowed on resource "User#null" with privilege "update"', $acl->getLastDenialMessage());
}

/**
* @requires PHP 7.3
*/
public function testMultipleReasons(): void
{
$acl = new class() extends Acl {
Expand Down

0 comments on commit 796b7a6

Please sign in to comment.