Added favicon to the website which will make the site look great. #11603
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hmmm, looks like this change breaks the build |
|
@eshellman Yes the build will break for this PR as I have added the favicon icon and nothing else.The site uses Jekyll theme and uses a remote theme from minimal so I just injected favicon in the |
|
Maybe you need to inject it from the free-programming-ebooks-search repo? |
|
@eshellman Okay I will do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve repo
Description
Added favicon to the site which will make the site look great fixes #11337 I have tested the site locally through github pages and it works great :).I have added the ebookfoundation logo as the favicon.
Why is this valuable (or not)?
Yes it is very valuable
Checklist:
Follow-up