Add new "rawHtmlOutput" option to TextEditorField #5156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to optionally enable raw HTML output in detail action and inside modal content (on index action). Relates: EasyCorp#5155
|
Looks good to me. I did a template override to addresss this, but this feels cleaner |
|
After submitting this PR, I've realized that the link in index view to open the modal is always being displayed, also when the contents are empty. To cover this I've also overrided the template in the end. But when using this field type, you always get HTML output (or empty string). To provide this as option makes still sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To optionally enable raw HTML output in detail action
and inside modal content (on index action).
Relates: #5155