-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render local UI within chatbox so it always has the same Z pos as the chatbox #134
base: master
Are you sure you want to change the base?
Conversation
@@ -17,9 +17,18 @@ function panel:Think() | |||
end | |||
|
|||
panel:SetWide(150) | |||
panel:SetZPos(-32768) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this particular Z index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minimal value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont get why you need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make panel's hitbox not overlap with anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unnecessarily high value. This will suffice.
panel:SetZPos(-32768) | |
panel:SetZPos(-5) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My point is that why is there a need to change the z index of this panel in particular, what is it overlapping that it should be underneath everything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My guess they encountered a bug it overlaps with another UI layer but I find it highly implausible to happen in normal use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole point of this PR was to make message receivers panel to be rendered together with the chatbox on the same level, but the message receivers panel itself should not prevent other panels from being clickable + the panel has nothing to click so there's no point in it being clickable and moreover preventing any other panels from being clicked.
No description provided.