Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render local UI within chatbox so it always has the same Z pos as the chatbox #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AokiAreAoki
Copy link
Contributor

No description provided.

lua/easychat/client/vgui/chatbox_panel.lua Outdated Show resolved Hide resolved
@@ -17,9 +17,18 @@ function panel:Think()
end

panel:SetWide(150)
panel:SetZPos(-32768)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this particular Z index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimal value

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont get why you need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make panel's hitbox not overlap with anything

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unnecessarily high value. This will suffice.

Suggested change
panel:SetZPos(-32768)
panel:SetZPos(-5)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My point is that why is there a need to change the z index of this panel in particular, what is it overlapping that it should be underneath everything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My guess they encountered a bug it overlaps with another UI layer but I find it highly implausible to happen in normal use.

Copy link
Contributor Author

@AokiAreAoki AokiAreAoki Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole point of this PR was to make message receivers panel to be rendered together with the chatbox on the same level, but the message receivers panel itself should not prevent other panels from being clickable + the panel has nothing to click so there's no point in it being clickable and moreover preventing any other panels from being clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants