Update deposition #11
Conversation
…e Cl.yml julia version
src/dry_deposition.jl
Outdated
| k = 1.3806488e-23u"m^2*kg*s^-2/K" # Boltzmann constant | ||
| M_air = 28.97e-3u"kg/mol" # molecular weight of air | ||
| R = 8.3144621u"J/K/mol" # Gas constant | ||
| @constants g = 9.81 [unit = u"m*s^-2"] # gravitational acceleration [m/s2] |
There was a problem hiding this comment.
For these constants (and other parameters and variables), instead of having the description as a comment, we can add it as description metadata, e.g.:
@constants g = 9.81 [unit = u"m*s^-2" description="gravitational acceleration"]
src/dry_deposition.jl
Outdated
| @constants κ = 0.4 # von Karman constant | ||
| @constants k = 1.3806488e-23 [unit = u"m^2*kg*s^-2/K"] # Boltzmann constant | ||
| @constants M_air = 28.97e-3 [unit = u"kg/mol"] # molecular weight of air | ||
| @constants R = 8.3144621 [unit = u"kg*m^2*s^−2*K^-1*mol^-1"] # Gas constant | ||
|
|
||
| """ | ||
| Function Ra calculates aerodynamic resistance to dry deposition | ||
| where z is the top of the surface layer [m], z₀ is the roughness length [m], u_star is friction velocity [m/s], and L is Monin-Obukhov length [m] | ||
| Based on Seinfeld and Pandis (2006) [Seinfeld and Pandis (2006)] equation 19.13 & 19.14. |
There was a problem hiding this comment.
Replace "[Sienfeld and Pandis (2006)]" with the full citation.
src/dry_deposition.jl
Outdated
| d = DrydepositionG(t) | ||
| ``` | ||
| """ | ||
|
|
There was a problem hiding this comment.
Remove empty line between function and function description
src/dry_deposition.jl
Outdated
| return Dₚ^2*ρₚ*g*Cc/(18*μ) | ||
| end | ||
| IfElse.ifelse((Dₚ > 20.e-6*unit_m), 99999999*unit_v, Dₚ^2*ρₚ*g*Cc/(18*μ)) | ||
| # if Dₚ > 20.e-6u"m" |
There was a problem hiding this comment.
Delete obsolete code rather than commenting it out.
|
|
||
| new(ODESystem(eqs, t, [SO2, O3], [cloudFrac, qrain, ρ_air, Δz]; name=:Wetdeposition)) | ||
| end | ||
| end |
There was a problem hiding this comment.
If we have code to couple deposition and superfast, we should add that too.
There was a problem hiding this comment.
I didn't put the code to couple deposition and superfast here because it requires using GasChem.jl, which is just a repo instead of a package. Should we make GasChem.jl a package first?
There was a problem hiding this comment.
I think it is a package! https://juliahub.com/ui/Search?q=earthsciml&type=packages
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #11 +/- ##
===========================================
- Coverage 93.67% 80.45% -13.22%
===========================================
Files 4 4
Lines 158 174 +16
===========================================
- Hits 148 140 -8
- Misses 10 34 +24 ☔ View full report in Codecov by Sentry. |
No description provided.