Skip to content

Commit

Permalink
Address two Fixme Comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ax3l authored Sep 3, 2024
1 parent ac9ff7f commit ba017dc
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions Examples/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,10 @@ function(add_warpx_test
)

# set Python executable
set(THIS_Python_EXE) # FIXME unsetting a variable can expose a cache variable that was previously hidden
if(python)
set(THIS_Python_EXE ${Python_EXECUTABLE})
else()
set(THIS_Python_EXE "")
endif()

# test run
Expand Down Expand Up @@ -172,9 +173,10 @@ function(add_warpx_test
# run all tests with 1 OpenMP thread by default
set_property(TEST ${name}.run APPEND PROPERTY ENVIRONMENT "OMP_NUM_THREADS=1")

set(THIS_Python_SCRIPT_EXE) # FIXME unsetting a variable can expose a cache variable that was previously hidden
if(python OR WIN32)
set(THIS_Python_SCRIPT_EXE ${Python_EXECUTABLE})
else()
set(THIS_Python_SCRIPT_EXE "")
endif()

# test analysis
Expand Down

0 comments on commit ba017dc

Please sign in to comment.