Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix failure of conda-lock in CI #3773

Closed
wants to merge 2 commits into from

Conversation

maresb
Copy link

@maresb maresb commented Oct 15, 2024

No description provided.

@maresb maresb requested a review from valeriupredoi as a code owner October 15, 2024 14:24
@maresb
Copy link
Author

maresb commented Oct 15, 2024

I can trigger workflow dispatch from my fork, but I'm getting a strange Bash error. I don't have any more time at the moment, but please try with mamba<2 and see if that solves it. If not we'll go deeper.

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 15, 2024

Hi Ben, many thanks for dropping by! I am not sure you are allowed to run our GAs off a fork PR, but I ported your changes in #3771 - try triggering the GAs in your fork too, but for them to run you'll have to delete the Mambaforge line since they are serving us a brownout today to make us move to Miniforge3 (which I am right now) 🍺

@valeriupredoi
Copy link
Contributor

I can trigger workflow dispatch from my fork, but I'm getting a strange Bash error. I don't have any more time at the moment, but please try with mamba<2 and see if that solves it. If not we'll go deeper.

ah I was just typing meself, many thanks! I'll take it from 'ere, mate 🍺

@valeriupredoi
Copy link
Contributor

ported this off-fork in regular PR #3771 - great idea! 🍺

@maresb
Copy link
Author

maresb commented Oct 15, 2024

Thanks for putting me out of my misery here, I was wondering why everything was failing.

you'll have to delete the Mambaforge line since they are serving us a brownout today

Ah, I was unaware that Mambaforge was deprecated. I would rather recommend migrating to setup-micromamba, at least once they get these v2 issues sorted. This is the only time I've had a bad experience with it.

I want to release a new version of conda-lock, but I decided to postpone due to issues with mamba v2, and not wanting to add any more variables into the mix before that's all stabilized. I'd be interested in making a MWE out of this and associating it to one of the open issues in mamba-org/mamba (or creating a new one in the unlikely event that this is not yet reported). So it would be good to get something under my control to run.

@valeriupredoi
Copy link
Contributor

valeriupredoi commented Oct 15, 2024

yeah I postponed retiring Mambaforge until someone told me about the brownouts today, when it was clear I have to act 🔨 We've been using conda-incubator/setup-miniconda for a long while, am quite happy with that action, stable and with good support (eg the guy who pointed me to those brownouts being announced is from conda-incubator

@maresb
Copy link
Author

maresb commented Oct 15, 2024

Actually, even better than Mamba is pixi, a new project-centric Conda environment manager with built-in lockfile support. It's a lot more stable than conda-lock, especially for mixed conda/pip environments.

@maresb
Copy link
Author

maresb commented Oct 15, 2024

@valeriupredoi, I wasn't able to reproduce the failure locally. Could I please ask a favor from you?

Could you reproduce the KeyError, and but with the following modifications?

  • Just before running conda-lock could you run mamba env export
  • Inside the conda-lock command could you add --log-level=DEBUG

@valeriupredoi
Copy link
Contributor

Sure thing! Will do that tomorrow, am off home for the day, mate 👍

@valeriupredoi
Copy link
Contributor

@valeriupredoi, I wasn't able to reproduce the failure locally. Could I please ask a favor from you?

Could you reproduce the KeyError, and but with the following modifications?

* Just before running `conda-lock` could you run `mamba env export`

* Inside the conda-lock command could you add `--log-level=DEBUG`

Ben, see #3780 (sorry, took me a while, emergency getting us rid of Mambaforge)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants