-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clm60 finidat updates for ne30, f09, f19 grids #2821
Conversation
./rimport-ing the following files:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Latest tests on derecho |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the settings for init_interp_attributes and finidat attributes look wrong to me. So we should make sure we've got this right.
@slevis-lmwg and I went over this, and figured out what we thought was correct for one of the cases, and he'll do the same changes for the other cases and test standard cases to make sure they get the right files. I'll look it over again and approve. And then I'll do some more namelist testing to make sure it's correct with the build-namelist tester and compare_namelists. Then Sam will proceed forward with updating to the b4b-dev tag and running aux_clm. So checkboxes...
|
Manual testing
@ekluzek the first five tests worked, BUT
|
slevis resolved conflicts: doc/ChangeLog doc/ChangeSum
…, handle 1979 finidat settings consistently for f09, f19, and ne30pg3
I pulled the latest commit and submitted
|
Description of changes
finidat updates needed for cesm's beta04 tag.
Specific notes
Contributors other than yourself, if any:
@ekluzek @olyson
CTSM Issues Fixed (include github issue #):
Relates to #2403 (I'm not confident that this fully resolves it though)
Are answers expected to change (and if so in what way)?
Yes, for clm6 ne30, f09, f19 cases, because pointing to new finidat files.
Any User Interface Changes (namelist or namelist defaults changes)?
Updated namelist_defaults with new finidat files.
Does this create a need to change or add documentation? Did you do so?
No but reminder to
Testing performed, if any:
izumi
./run_sys_tests -s aux_clm -c ctsm5.3.003 --skip-generate
Compared to 003 because 004 was not available.
004 would differ from 003 only for the hillslope test, which is a clm6 test, so I expect it to differ already due to my mods.
So then, expected due my mods:
New FAILs for clm6 tests in the NLCOMP phase (due to namelist changes) and the BASELINE phase (due to changing answers).