Fix error in view factor for urban building energy model #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olyson
added
the
next
6 tasks
slevis-lmwg
added a commit
to slevis-lmwg/ctsm
that referenced
this pull request
Jan 17, 2024
ekluzek
removed
the
next
ekluzek
approved these changes
Jan 19, 2024
|
@slevis-lmwg is bringing this in. |
slevis-lmwg
added a commit
that referenced
this pull request
Jan 20, 2024
Merge tag: Turn on Meier2022, tillage, residue removal; bring in #2212
olyson
added a commit
to olyson/ctsm
that referenced
this pull request
Feb 28, 2024
Turn Meier2022, tillage, and residue removal on for ctsm5.1, fix ESCOMP#2212 Answer-changing merge-tag: - Turn Meier2022 on for ctsm5.1. Had turned off temporarily while fixing a bug. - Bring in Urban answer fix ESCOMP#2212. - Turn tillage and residue removal on for ctsm5.1. Changes made to namelist defaults (e.g., changed parameter values): - Making Meier2022 the default for ctsm5.1 again. - Making tillage low by default for ctsm5.1. - Making residue removal 0.5 by default for ctsm5.1. Summarize any changes to answers, i.e., - what code configurations: ALL - what platforms/compilers: ALL - nature of change: clm45 and clm50: larger than roundoff clm51: possibly climate changing Effect of Meier2022 was documented here: NCAR/LMWG_dev#38 Effect of tillage and residue removal may require an Answer Changing Tag simulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Linying Wang and Dan Li (Boston University) reported problems with energy balance of longwave radiation in the building energy model (BEM).
This is due to an error in one of the view factors (vf_fw - view factor for floor to wall). There is an energy balance check related to this, but it is also formulated incorrectly and thus balances for the wrong reason.
This is fixed with this PR.
Specific notes
Contributors other than yourself, if any: Linying Wang and Dan Li (Boston University)
CTSM Issues Fixed (include github issue #): #2208
Are answers expected to change (and if so in what way)? Larger than roundoff but not urban climate changing (see analysis in #2208 )
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any:
Ran clm_short test suite on cheyenne. All pass except for baseline comparisons as expected. Ran one CLM45 test (ERS_D_Ld6.f10_f10_mg37.I1850Clm45BgcCrop.cheyenne_intel.clm-clm50CMIP6frc) which was BFB as expected.