Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate clm5_1 physics with ctsm5.2.0 #2379

Open
7 tasks done
ekluzek opened this issue Feb 20, 2024 · 6 comments · Fixed by #2808
Open
7 tasks done

Deprecate clm5_1 physics with ctsm5.2.0 #2379

ekluzek opened this issue Feb 20, 2024 · 6 comments · Fixed by #2808
Assignees
@slevis-lmwg
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) done Issues whose closing PR is done but not yet merged (pending test re-run ok) enhancement new capability or improved behavior of existing capability external issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking good first issue simple; good for first-time contributors
Milestone
CESM3 Answer chan...

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Feb 20, 2024 •
edited by slevis-lmwg
Loading

With #2378 and ctsm5.2.0 made, we need to deprecate and eventually remove the clm5_1 physics option to CLM_PHYSICS_VERSION. We need to leave it in place until other components: CISM, CAM, and CMEPS have removed it's usage and are only using: clm4_5, clm5_0, or clm6_0.

Definiton of done:

  • Remove all Clm51 tests from our testlists switch them to Clm60 (just remove if there's an existing Clm60 one)
  • Remove the option in config_components.xml
  • Remove the compsets in config_compsets.xml
  • Changes to build-namelist to remove the option for clm5_1
  • Remove mention of clm5_1 in the code
  • Remove mention of clm5_1 in documentation
  • ./rimport renamed file: .../lnd/clm2/paramdata/ctsm60_ciso_cwd_hr_params.c240814.nc
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability code health improving internal code structure to make easier to maintain (sustainability) tag: simple bfb labels Feb 20, 2024
This was referenced Mar 6, 2024
Closed
Open
This was referenced May 1, 2024
Closed
Open
@ekluzek
Copy link
Collaborator Author

ekluzek commented May 1, 2024 •
edited
Loading

Issues in other components are here:

Those required before removal of clm5_1:

Those that merely update tests from clm5_0 to clm6_0: (so not required for removal)

This was referenced May 1, 2024
Merged
Merged
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jul 31, 2024

This has happened in CAM and CESM which is the biggest lift. There is only a small change to CMEPS that is required now.

@samsrabin samsrabin added simple bfb bit-for-bit and removed simple bfb labels Aug 8, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 25, 2024

In the latest ctsm5.2 tags as well as ctsm5.3.0 clm5_1 and clm6_0 are out of sync with differences in the namelist. Therefore removing clm5_1 is a bigger priority since it's now wrong.

@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 25, 2024
@samsrabin samsrabin added this to the cesm3_0_beta04 milestone Sep 26, 2024
@ekluzek ekluzek removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Sep 27, 2024
@ekluzek ekluzek mentioned this issue Sep 27, 2024
Closed
@slevis-lmwg slevis-lmwg mentioned this issue Oct 2, 2024
Open
@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Oct 2, 2024 •
edited
Loading

Issues in other components are here:

Those required before removal of clm5_1:
[...]

  • @ekluzek speaking of other components, I found a Clm51Sp test in testlist_mosart.xml

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Oct 2, 2024 •
edited
Loading

Testing on derecho:

  • PASS make black and make lint
  • PASS ./run_ctsm_py_tests -s and ./run_ctsm_py_tests -u
  • PASS ./build-namelist_test.pl
  • IN PROGRESS aux_clm without mods to the submodules, yet

@slevis-lmwg slevis-lmwg mentioned this issue Oct 2, 2024
Merged
@slevis-lmwg slevis-lmwg moved this from Todo to In Progress in LMWG: Near Term Priorities Oct 2, 2024
@samsrabin samsrabin added good first issue simple; good for first-time contributors and removed simple labels Oct 3, 2024
@slevis-lmwg slevis-lmwg moved this from In Progress to Done in LMWG: Near Term Priorities Oct 24, 2024
@slevis-lmwg slevis-lmwg added the external issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking label Oct 24, 2024
@ekluzek ekluzek added the done Issues whose closing PR is done but not yet merged (pending test re-run ok) label Nov 26, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 4, 2024

The only part of this left to do is to update the following submodules when they have updated to NOT use clm51 and use clm60 in testing:

  • mizuRoute
  • CISM
  • CMEPS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slevis-lmwg slevis-lmwg

Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) done Issues whose closing PR is done but not yet merged (pending test re-run ok) enhancement new capability or improved behavior of existing capability external issue needs to be addressed elsewhere (submodule); issue here for the sake of project tracking good first issue simple; good for first-time contributors
Projects
LMWG: Near Term Priorities
Status: Done
Milestone
CESM3 Answer changing freeze
Development

Successfully merging a pull request may close this issue.

Remove Clm51 references throughout or change to Clm60 slevis-lmwg/ctsm
3 participants
@samsrabin @ekluzek @slevis-lmwg