Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpointer timestamp #311

Merged
merged 16 commits into from
Oct 15, 2024
Merged

Conversation

jedwards4b
Copy link
Contributor

Description of changes

This PR adds timestamps to the rpointer file names. It is done in a backward compatible manor so that the current rpointer files naming scheme will still work.

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs (if so list):
This depends on ESCOMP/CESM_share#53

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc): aux_cdeps, all pass

Hashes used for testing:

@jedwards4b jedwards4b self-assigned this Sep 6, 2024
@mvertens
Copy link
Collaborator

mvertens commented Oct 1, 2024

@jedwards4b - I think that a few tests with active components would be important to do as well before this PR is merged.
I would suggest 3 tests - F, I and G compsets.

Copy link
Collaborator

@mvertens mvertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this PR. Can you please address my questions.
Also - I think that a few tests with active components would be important to do as well before this PR is merged. I would suggest 3 tests - F, I and G compsets.

cime_config/config_compsets.xml Outdated Show resolved Hide resolved
dglc/dglc_datamode_noevolve_mod.F90 Show resolved Hide resolved
share/nuopc_shr_methods.F90 Show resolved Hide resolved
@jedwards4b
Copy link
Contributor Author

Thank you @mvertens I am completeing a full set of cesm3 prealpha tests.

@jedwards4b jedwards4b requested review from mvertens and removed request for mvertens October 14, 2024 19:01
@jedwards4b
Copy link
Contributor Author

@mvertens I have completed prealpha and prebeta tests using cesm3_0_beta03 as a baseline.

@jedwards4b jedwards4b merged commit 1eacdcc into ESCOMP:main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants