Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZM CCPP'ization round 4 (completes CCPP conversion of ZM) #1218

Open
wants to merge 17 commits into
base: cam_development
Choose a base branch
from

Conversation

cacraigucar
Copy link
Collaborator

This round of cleanup completes moving ZM to CCPP

closes #873

Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cacraigucar! I went through this PR first since I pulled a few of the changes in this PR into my Hack shallow convection work. I just had two (hopefully easy to resolve) questions (on the water vapor standard name and another on cloud_fraction_fice).

src/utils/cam_ccpp/ccpp_constituent_prop_mod.F90 Outdated Show resolved Hide resolved
src/physics/cam/zm_conv_intr.F90 Show resolved Hide resolved
@cacraigucar cacraigucar requested a review from jimmielin January 6, 2025 16:39
Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @cacraigucar for addressing my comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants