Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_052: clubb_intr GPUization #1175

Merged
merged 20 commits into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
37430e1
Manually merging in changes from ew-develop
huebleruwm Oct 12, 2024
9427505
Adding acc data statement outside substepping loop and preventing som…
huebleruwm Oct 12, 2024
6a38ec2
Replacing vector notation with loops, rearranging some things, genera…
huebleruwm Oct 12, 2024
94ba629
More small changes
huebleruwm Oct 14, 2024
7b94963
Some GPUization.
huebleruwm Oct 14, 2024
7786cca
Small bug fixes
huebleruwm Oct 15, 2024
0d391b1
Tweaks to acc data statement. This version passed the GPU ect test.
huebleruwm Oct 15, 2024
cf58834
More GPUization and small changes. ECT passed on CPU and GPU.
huebleruwm Oct 16, 2024
e39e8a3
Bug fix that scarily did not break the CPU ECT test, but was detected…
huebleruwm Oct 16, 2024
e5e81fb
More GPUization. ECT passes for CPU and GPU, CPU is BFB.
huebleruwm Oct 16, 2024
87af330
Adding/moving timing statements
huebleruwm Oct 17, 2024
c85778e
Small cleanup and a little more GPUization. Passes ECT CPU vs GPU tes…
huebleruwm Oct 18, 2024
cfd2824
Small updates to comments and indenting
huebleruwm Oct 25, 2024
75f51d1
Making nzm_clubb and nzt_clubb module parameters that are initialized…
huebleruwm Oct 28, 2024
b1a243c
Adding timer around all code in the do_rainturb option rather than ju…
huebleruwm Nov 11, 2024
4c48fcf
Merge remote-tracking branch 'upstream/cam_development' into clubb_in…
nusbaume Dec 31, 2024
88bf778
Add comments describing new vertical level variables.
nusbaume Dec 31, 2024
bcdd606
Merge remote-tracking branch 'upstream/cam_development' into clubb_in…
nusbaume Jan 3, 2025
8582fd5
Fix bugs found with GNU regression tests.
nusbaume Jan 5, 2025
87cb006
Update ChangeLog.
nusbaume Jan 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 59 additions & 0 deletions doc/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,5 +1,64 @@
===============================================================

Tag name: cam6_4_052
Originator(s): huebleruwm, nusbaume
Date: 6 Jan 2025
One-line Summary: clubb_intr GPUization
Github PR URL: https://github.com/ESCOMP/CAM/pull/1175

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Adds OpenACC directives to clubb_intr.F90 to enable GPU offloading of CLUBB.
BFB on CPUs, answer changing (but passes ECT) on GPUs.

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by: nusbaume, katetc, cacraigucar

List all files eliminated: N/A

List all files added and what they do: N/A

List all existing files that have been modified, and describe the changes:
M src/physics/cam/clubb_intr.F90
- add OpenACC directives for GPU offloading
- add timer calls to evaulate performance

If there were any failures reported from running test_driver.sh on any test
platform, and checkin with these failures has been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam:

DIFF SMS_Lh12.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq3h
FAIL ERP_Ln9.f09_f09_mg17.FCSD_HCO.derecho_intel.cam-outfrq9s
- pre-existing failure due to HEMCO not having reproducible results issues #1018 and #856

PEND SMS_D_Ln9.f19_f19_mg17.FXHIST.derecho_intel.cam-outfrq9s_amie
FAIL SMS_D_Ln9_P1280x1.ne0CONUSne30x8_ne0CONUSne30x8_mt12.FCHIST.derecho_intel.cam-outfrq9s
- pre-existing failures due to build-namelist error requiring CLM/CTSM external update.

derecho/nvhpc/aux_cam:

ERS_Ln9.ne30pg3_ne30pg3_mg17.F2000dev.derecho_nvhpc.cam-outfrq9s_gpu_default (Overall: FAIL)
- Expected baseline failures due to non-BFB answer changes with new CLUBB GPU-offloading.

izumi/nag/aux_cam:
FAIL DAE.f45_f45_mg37.FHS94.izumi_nag.cam-dae
- pre-existing failure -- issue #670

izumi/gnu/aux_cam: ALL PASS

===============================================================
===============================================================

Tag name: cam6_4_051
Originator(s): fvitt
Date: 2 Jan 2025
Expand Down
Loading
Loading