Support for enabling optional MPAS features through CIME #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid using recursively expanded variables due to performance reasons. Instead, use simply expanded variables where possible.
The `USE_PIO2` macro is an implementation detail of MPAS. We should not let CIME to set it for us, and CIME really should not have included that logic in the first place. When CIME invokes its Makefile, `PIO_VERSION` is always supplied as a command line argument. Therefore, we can reliably use it to determine if the `USE_PIO2` macro should be set.
Query relevant configuration options from CIME, and determine if certain optional MPAS features can be enabled.
nusbaume
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
None
Originator(s):
kuanchihwang
Descriptions (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
This PR refactors the build system of MPAS dycore. Build performance has been improved. PIO version selection is now more robust. The availability of optional MPAS features is now determined by querying relevant configuration options from CIME rather than being hard-coded.
MPAS dycore is in double precision mode by default. Users can choose to enable single precision mode by running:
./xmlchange --append CAM_CONFIG_OPTS="--dyn_kind REAL32"Closes #347.
Describe any changes made to the build system:
See above.
Describe any changes made to the namelist:
None
List any changes to the defaults for the input datasets (e.g., boundary datasets):
None
List all files eliminated and why:
None
List all files added and what they do:
None
List all existing files that have been modified, and describe the changes:
M cime_config/buildlibM src/dynamics/mpas/assets/Makefile.in.CESMRegression tests:
No changes to any existing tests. All tests pass with respect to the last baseline,
sima0_01_001.