Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UART example compilation #3

Merged

Conversation

brainstorm
Copy link
Contributor

Also other minor defects elsewhere.

Needs to be tested on a device, I only needed to check some assembly details (calling convention for SDCC on STM8).

Copy link
Member

@SaeidYazdani SaeidYazdani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Amazing to see that someone showed up after so many years 👍

@SaeidYazdani SaeidYazdani merged commit 3bb5c6c into EMBEDONIX:master Oct 24, 2024
@brainstorm
Copy link
Contributor Author

brainstorm commented Oct 27, 2024

Amazing to see that someone showed up after so many years

Thank you! Although to be fair, I'd recommend using https://github.com/gicking/STM8_headers instead of this repo as it contains higher quality examples and they compile out of the box.

Kudos to @gicking in issue #2 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants