-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init/runoff #156
Open
tommylees112
wants to merge
773
commits into
master
Choose a base branch
from
init/runoff
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Init/runoff #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create_raw_input_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
Create xy samples dynamically from Data loaded into memory
sorry this is a huge PR where we have basically re-written the Engineer/DataLoaders/Models to work with data loaded into memory. Better for
hard disk constrained
modelling problems where the size of theseq_length
is larger (e.g. 365 daily timesteps as input to the LSTM models).Use the Pipeline for working with runoff data.
station_id, time
)daily
)'seq_length', 'target_var', 'forecast_horizon'
We have created an experiment file for running the OneTimestepForecast Runoff modelling:
scripts/experiments/18_runoff_init.py
Analysis updates
We have added some updates to the analysis code:
lat, lon
is reversed ->lon, lat
Engineer updates
OneTimestepForecast
-src/engineer/one_timestep_forecast.py
NOTE do we want this or do we ideally want to generalise the one_month_forecast?
lat, lon
but bydimension_name = [c for c in static_ds.coords][0]
DataLoader Updates
self.get_reducing_dims
to get the spatial dimensions (either latlon or area or station_id or whatever is not time!)global_mean = x.mean(dim=reducing_dims)
build_loc_to_idx_mapping
building a dictionary to ensure we can track what id relates to what spatial unitif len(static_np.shape) == 3:
having to account for 2D spatial information (time, lat, lon) or 1D spatial information (time, station_id)TODO:
# TODO: why so many static nones?
Model updates
seq_length
//include_timestep_aggs
for x, y in tqdm.tqdm(train_dataloader):
include_monthly_aggs
->include_timestep_aggs
= spatial aggregation (map of mean values for that pixel)