Feature/explicit studies privacy check #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
release v2.4.39
Metagenomics Exchange upload command and related bookkeeping code
mberacochea
reviewed
May 1, 2024
| url = f"{'https://www.ebi.ac.uk/ena/submit/report/studies'}/{study_id}" | ||
| ena_api_password = EMG_CONF['emg']['ena_api_password'] | ||
| if not ena_api_password: | ||
| logging.warning("ENA API password is missing. Study ownership cannot be verified.") |
There was a problem hiding this comment.
Suggested change
| logging.warning("ENA API password is missing. Study ownership cannot be verified.") | |
| logging.error("ENA API password is missing. Study ownership cannot be verified.") |
There was a problem hiding this comment.
thanks @mberacochea .
The idea here is to allow this part to continue when the CI pipeline is running.
Since in the pipeline config, the ena_api_password is kept empty
There was a problem hiding this comment.
That is fine, but in case this happens by accident I would print that in the error log file
Co-authored-by: Martín Beracochea <[email protected]>
Co-authored-by: Martín Beracochea <[email protected]>
Co-authored-by: Martín Beracochea <[email protected]>
Co-authored-by: Martín Beracochea <[email protected]>
Added try catch and exlplict check for 200 responses from ENA API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.