-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zppy pcmdi new #656
base: zppy_pcmdi
Are you sure you want to change the base?
Zppy pcmdi new #656
Conversation
Changes are made in the pcmdi_diags.bash to change the worflow to be more modulized and easier to read
variables were not included in e3sm_to_cmip module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes from Shixuan: The changes made in this file are to a. clean up the redundant setup parameters and 2. add a new block "synthetic_plots" that is to create the summary metrics (portrait plots and parallel coordinate plots for comparison of e3sm with existing cmip6 diagnostics).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes from Shixuan : The changes made in this file are mainly to a. add the update following e3sm_diags.py and b. add code block here to deal with the external function module and parameter files that will be needed for the pcmdi-pmp diagnostics.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes from Shixuan: This file was significantly reorganized to address the concerns raised by zppy developers.
Issue resolution
Select one: This pull request is...
1. Does this do what we want it to do?
Objectives:
Required:
If applicable:
2. Are the implementation details accurate & efficient?
Required:
If applicable:
zppy/conda
, not just animport
statement.3. Is this well documented?
Required:
4. Is this code clean?
Required:
If applicable: