Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CIME submodule #6898

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update CIME submodule #6898

wants to merge 5 commits into from

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented Jan 15, 2025

... to 954266b46ec8e32ea222322602d7fcff76d3bf5a

Fixes:

  1. fix the restart tests by using ceil instead of int
  2. Fix for PES append feature
  3. MVK/PGN: Import the shutil module rather than the "shutils" module typo
  4. Fix BFAILs, they need to be considered DIFF
  5. avoid breaking Python environment by prepending CIME paths to PYTHONPATH
  6. Remove distutils
  7. Fixes test status reporting errors during successful baseline comparison
  8. check_input_data: skip three files when staging refcase files to avoid a rmtree error
  9. Fix multidriver for MCT: logic was incorrect
  10. Fixes compare_xml method for env_batch
  11. fix correction for no_leap calendar in tests
  12. correct rpointer name in resubmit
  13. create_clone: correct the SRCROOT path when using create_clone

Changes:

  1. create_test: add --driver support for e3sm
  2. make the hidden status of batch jobs xml dependent
  3. Mark SETUP as FAIL if case.cmpgen_namelists fails
  4. improve functionality of hidden workflow flag
  5. refine the git interface to handle no git and old git
  6. do not report memcomp if no baseline exists
  7. clarify prereq option in case.submit
  8. Add mem variables to env_batch
  9. Updates MVK SystemTest to be configurable via testmod
  10. If batch script is already executable, don't chmod it
  11. Add timing to git operations
  12. Add timestamp to rpointers
  13. case.run: add try except clauses to reduce errors in testing
  14. jenkins: Canceling batch jobs needs to happen immediately when a signal occurs.
  15. bless_test_results: Add option to lock baselines (remove group write)

[BFB]

... to 954266b46ec8e32ea222322602d7fcff76d3bf5a

Fixes:
1) fix the restart tests by using ceil instead of int
2) Fix for PES append feature
3) MVK/PGN: Import the shutil module rather than the "shutils" module typo
4) Fix BFAILs, they need to be considered DIFF
5) avoid breaking Python environment by prepending CIME paths to PYTHONPATH
6) Remove distutils
7) Fixes test status reporting errors during successful baseline comparison
8) check_input_data: skip three files when staging refcase files to avoid a rmtree error
9) Fix multidriver for MCT: logic was incorrect
10) Fixes compare_xml method for env_batch
11) fix correction for no_leap calendar in tests
12) correct rpointer name in resubmit
13) create_clone: correct the SRCROOT path when using create_clone

Changes:
1) create_test: add --driver support for e3sm
2) make the hidden status of batch jobs xml dependent
3) Mark SETUP as FAIL if case.cmpgen_namelists fails
4) improve functionality of hidden workflow flag
5) refine the git interface to handle no git and old git
6) do not report memcomp if no baseline exists
7) clarify prereq option in case.submit
8) Add mem variables to env_batch
9) Updates MVK SystemTest to be configurable via testmod
10) If batch script is already executable, don't chmod it
11) Add timing to git operations
12) Add timestamp to rpointers
13) case.run: add try except clauses to reduce errors in testing
14) jenkins: Canceling batch jobs needs to happen immediately when a signal occurs.
15) bless_test_results: Add option to lock baselines (remove group write)

[BFB]
@jgfouca jgfouca added BFB PR leaves answers BFB CIME labels Jan 15, 2025
@jgfouca jgfouca requested review from rljacob and jasonb5 January 15, 2025 18:03
@jgfouca jgfouca self-assigned this Jan 15, 2025
@jgfouca
Copy link
Member Author

jgfouca commented Jan 15, 2025

I really waited too long to do a CIME update, so this will be a big update.

@rljacob
Copy link
Member

rljacob commented Jan 23, 2025

how is this going?

@jgfouca
Copy link
Member Author

jgfouca commented Jan 23, 2025

@rljacob , I think it's close. I worked with @jedwards4b to fix the last few issues yesterday.

@jgfouca
Copy link
Member Author

jgfouca commented Feb 3, 2025

Merged to next.

@rljacob
Copy link
Member

rljacob commented Feb 4, 2025

Is this PR responsible for these namelist changes in the ERS and ERP tests?

 BASE: restart_n = 6
  COMP: restart_n = 11

@jgfouca
Copy link
Member Author

jgfouca commented Feb 4, 2025

@rljacob , yes. The restart_n in the baselines is not even correct.

jgfouca added a commit that referenced this pull request Feb 5, 2025
Merge 2 for this PR.

[BFB]

* jgfouca/cime_update_2025_01_15:
  Update python version on Anvil, Chrysalis, Aurora
jgfouca added a commit that referenced this pull request Feb 5, 2025
Merge 3 for this PR.

[BFB]

* jgfouca/cime_update_2025_01_15:
  Update python version on Anvil, Chrysalis, Aurora
Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but two todo items:

  • dashboard: add ERS tests for eamxx on the dashboard for next testing
  • gh/ci: activate eamxx/eam tests for whenever CIME is updated (we now only do W-compset fully-coupled tests, which evidently aren't enough because EAMxx uses different logic than eam in terms of restarts, etc.)

@ndkeen
Copy link
Contributor

ndkeen commented Feb 5, 2025

I'm getting error at setup/build with a test like
ERP_Lm3.ne4pg2_oQU480.F2010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB CIME
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants