Fixing a bug causing model crash by avoiding negative channel storage #6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there an issue for this bug? |
donghuix
reviewed
Aug 29, 2024
| else | ||
| TRunoff%erout(iunit,nt) = -(TRunoff%erlateral(iunit,nt) + TRunoff%erin(iunit,nt) + TRunoff%wr(iunit,nt)/ theDeltaT) | ||
| end if | ||
| TRunoff%erout(iunit,nt) = -(TRunoff%erlateral(iunit,nt) + TRunoff%erin(iunit,nt) + TRunoff%wr(iunit,nt)*MaxStorageDepleted/ theDeltaT) |
There was a problem hiding this comment.
I think this will result in non BFB in the MOSART simulation.
There was a problem hiding this comment.
You are right. This is non-BFB. It won't affect the overall model simulation (hence science), but it does change the results slightly for the rare cases when a whole channel storage is completely depleted. I added the "non-BFB" label.
There was a problem hiding this comment.
Since its potentially non-BFB, this fix would have to go in with 3.1
This was referenced Sep 17, 2024
bpbond
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOSART can be forced to crash if negative channel storage values are produced mainly due to round errors, when the channel storage is completely depleted in a single time step. The crashing was reported in several cases of E3SM fully coupled runs, where the kinematic waving routing method was invoked by default. Jon Wolfe was able to reproduce the crashing error in a low-res run and print out detailed information to identify the cause. In this fix, a numerical treatment has been implemented in the kinematic wave routing method, subroutine Routing_KW(), to ensure that any channel storage does not get completely depleted in a single time step. This treatment is physically reasonable as long as MOSART runs at a sub-daily time step. Jon Wolfe has tested this treatment in his low-res coupled run, and it helped avoid crashing.