Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rbac for otel collector with open signal #4403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andriisoldatenko
Copy link
Contributor

@andriisoldatenko andriisoldatenko commented Feb 4, 2025

Description

This PR assign additional permission to the OpenTelemetry collector for OpenSignals collection. Those are required by the processors inside the OTelC to collect additional enrichment data from the K8S cluster.

How can this be tested?

make test/helm

or deploy operator with branch and check list of ClusterRoles.

@andriisoldatenko andriisoldatenko force-pushed the rbac-for-otel-collector-w-open-signal branch from b61f056 to 4c9d9e8 Compare February 4, 2025 15:47
@andriisoldatenko andriisoldatenko changed the title rbac for otel collector w open signal Add rbac for otel collector with open signal Feb 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.36%. Comparing base (241f944) to head (2d8a52f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4403   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files         402      402           
  Lines       26554    26554           
=======================================
  Hits        17092    17092           
  Misses       8151     8151           
  Partials     1311     1311           
Flag Coverage Δ
unittests 64.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andriisoldatenko andriisoldatenko marked this pull request as ready for review February 4, 2025 16:19
@andriisoldatenko andriisoldatenko requested a review from a team as a code owner February 4, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants