Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Dynakube's config and enrichment secrets when deleting it #4047

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

albertogdd
Copy link
Contributor

Description

https://dt-rnd.atlassian.net/browse/DAQ-2266

Currently, dynatrace-dynakube-config and dynatrace-metadata-enrichment-endpoint secrets doesn't get deleted when the Dynakube gets deleted.

This PR adds the cleanup of those.

How can this be tested?

  • On main branch: deploy a DK and delete it, check that these secrets doesn't get deleted
  • On this branch: do the same and check that they get deleted

@albertogdd albertogdd added the bug Something isn't working label Nov 12, 2024
@albertogdd albertogdd requested a review from a team as a code owner November 12, 2024 14:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.66%. Comparing base (3075170) to head (46189bb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/injection/namespace/mapper/dynakubes.go 25.00% 4 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4047      +/-   ##
==========================================
- Coverage   64.66%   64.66%   -0.01%     
==========================================
  Files         397      397              
  Lines       26466    26478      +12     
==========================================
+ Hits        17115    17121       +6     
- Misses       8023     8027       +4     
- Partials     1328     1330       +2     
Flag Coverage Δ
unittests 64.66% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertogdd albertogdd requested a review from 0sewa0 November 14, 2024 09:03
waodim
waodim previously approved these changes Nov 14, 2024
Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it and the secrets get deleted - codewise nothing further to add from me

@albertogdd albertogdd merged commit 4853ad1 into main Nov 14, 2024
20 checks passed
@albertogdd albertogdd deleted the bug/cleanup-dynakube-config-secrets branch November 14, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants