-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Dynakube's config and enrichment secrets when deleting it #4047
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
==========================================
- Coverage 64.66% 64.66% -0.01%
==========================================
Files 397 397
Lines 26466 26478 +12
==========================================
+ Hits 17115 17121 +6
- Misses 8023 8027 +4
- Partials 1328 1330 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it and the secrets get deleted - codewise nothing further to add from me
Description
https://dt-rnd.atlassian.net/browse/DAQ-2266
Currently,
dynatrace-dynakube-config
anddynatrace-metadata-enrichment-endpoint
secrets doesn't get deleted when the Dynakube gets deleted.This PR adds the cleanup of those.
How can this be tested?