Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(convert)!: Remove monaco convert #1680

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(convert)!: Remove monaco convert #1680

wants to merge 2 commits into from

Conversation

Laubi
Copy link
Contributor

@Laubi Laubi commented Jan 30, 2025 •
edited
Loading

What this PR does / Why we need it:

This PR removes monaco convert and all dependent code completely.
This includes legacy e2e tests, config-, project-, and environment-v1, template, top sort, etc.

Does this PR introduce a user-facing change?

Yes. monaco convert will no longer be available.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2025 •
edited
Loading

Unit Test Results

1 752 tests   - 225   1 751 ✅  - 225   54s ⏱️ -1s
  129 suites  -   5       1 💤 ±  0 
    1 files   ±  0       0 ❌ ±  0 

Results for commit 8aa46cc. ± Comparison against base commit 5d28c1d.

This pull request removes 225 tests. 
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_FailsIfThereIsJustEmptyProjects
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_RemovesEscapeCharsAsV2AutoEscapes
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksIfNoDeleteYamlExists
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksOnFullConfiguration
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/copies_delete_file
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/does_nothing_if_no_delete_file_exists
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/returns_error_if_file_can't_be_accessed
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/returns_error_if_file_can't_be_read
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/returns_error_if_output_folder_can't_be_accessed
…

♻️ This comment has been updated with latest results.

@Laubi Laubi force-pushed the refactor/remove-monaco-convert branch from c2376e6 to 9006cea Compare February 3, 2025 15:02
@Laubi
feat(convert)!: Remove monaco convert
03ea1f2 
This changeset removes `monaco convert` and all dependent code.
This includes:
* config v1
* project v1
* environment v1
* templating
* endpoints v1
* topology sort
* legacy tests
@Laubi Laubi force-pushed the refactor/remove-monaco-convert branch from 9006cea to 03ea1f2 Compare February 3, 2025 15:05
@Laubi Laubi added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Feb 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

E2E Test Results

    3 files   -   2    259 suites   - 145   19m 55s ⏱️ - 1h 4m 17s
1 852 tests  - 246  1 850 ✅  - 246  2 💤 ±0  0 ❌ ±0 
2 004 runs   - 398  2 002 ✅  - 398  2 💤 ±0  0 ❌ ±0 

Results for commit 03ea1f2. ± Comparison against base commit 5d28c1d.

This pull request removes 246 tests. 
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_FailsIfThereIsJustEmptyProjects
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_RemovesEscapeCharsAsV2AutoEscapes
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksIfNoDeleteYamlExists
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestConvert_WorksOnFullConfiguration
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/copies_delete_file
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/does_nothing_if_no_delete_file_exists
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/returns_error_if_file_can't_be_accessed
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/returns_error_if_file_can't_be_read
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/convert ‑ TestCopyDeleteFileIfPresent/returns_error_if_output_folder_can't_be_accessed
…

@Laubi Laubi marked this pull request as ready for review February 3, 2025 15:30
@Laubi Laubi requested a review from a team as a code owner February 3, 2025 15:30
jskelin
jskelin previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@jskelin jskelin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.ci/nightly.groovy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this PR.
Can I remove this jenkins pipeline? I think it's obsolete.

@Kirdock
test: fix tests and workflow image
8aa46cc 
- Deleting the temp folder was not possible in some cases because the stream was not closed
- The Windows tests actually did not run on Windows but on Ubuntu
@dynatrace-cla-bot
Copy link

dynatrace-cla-bot commented Feb 4, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskelin jskelin jskelin left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Laubi @dynatrace-cla-bot @jskelin @Kirdock