Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use slog #1678

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

feat: Use slog #1678

wants to merge 8 commits into from

Conversation

arthurpitman
Copy link
Contributor

What this PR does / Why we need it:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Copy link

github-actions bot commented Jan 29, 2025

Unit Test Results

1 959 tests   - 18   1 958 ✅  - 18   54s ⏱️ -1s
  131 suites  -  3       1 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 8b9b13e. ± Comparison against base commit 5d28c1d.

This pull request removes 18 tests.
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Debug_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Error_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Info_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Warn_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestClone
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestEncodeEntry_IgnoresFieldsGivenViaArgs
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestEncodeEntry_UsesFieldsFromObjectEncoder
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestLoggerReturnsCustomLogLevell
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestLoggerReturnsDefaultLogLevel
…

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman added the run-e2e-test Manually trigger the E2E tests for reviewed PRs label Jan 30, 2025
Copy link

github-actions bot commented Jan 30, 2025

E2E Test Results

    4 files   -   1    264 suites   - 140   31m 56s ⏱️ - 45m 57s
2 078 tests  -  20  2 075 ✅  -  17  2 💤 ±0  1 ❌  - 3 
2 230 runs   - 172  2 227 ✅  - 169  2 💤 ±0  1 ❌  - 3 

For more details on these failures, see this check.

Results for commit 8b9b13e. ± Comparison against base commit 2b3313c.

This pull request removes 20 tests.
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationClassic
github.com/dynatrace/dynatrace-configuration-as-code/v2/cmd/monaco/integrationtest/v2 ‑ TestPaginationPlatform
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Debug_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Error_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Info_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestAllMethodsHaveFields/Warn_log_-_has_fields
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestClone
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestEncodeEntry_IgnoresFieldsGivenViaArgs
github.com/dynatrace/dynatrace-configuration-as-code/v2/internal/loggers/zap ‑ TestEncodeEntry_UsesFieldsFromObjectEncoder
…

♻️ This comment has been updated with latest results.

@arthurpitman arthurpitman added run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Jan 31, 2025
@arthurpitman arthurpitman added run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Feb 3, 2025
@arthurpitman arthurpitman added run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Feb 3, 2025
Copy link

sonarqubecloud bot commented Feb 3, 2025

@arthurpitman arthurpitman added run-e2e-test Manually trigger the E2E tests for reviewed PRs and removed run-e2e-test Manually trigger the E2E tests for reviewed PRs labels Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e-test Manually trigger the E2E tests for reviewed PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant