Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoboSub 2024 #555

Merged
merged 401 commits into from
Sep 7, 2024
Merged

RoboSub 2024 #555

merged 401 commits into from
Sep 7, 2024

Conversation

maxwellmlin
Copy link
Member

@maxwellmlin maxwellmlin commented Aug 31, 2024

See parent branch comp-2024 for original competition code. This comp-2024-refactor branch contains the refactored code to be merged into master.

@ChuChuCodes0414 ChuChuCodes0414 dismissed stale reviews from nathanaelren and themself August 31, 2024 17:32

hehe

co-authored-by: Mathew Chu <mc866@duke,.edu>

Fr this time last one
@ChuChuCodes0414 ChuChuCodes0414 self-requested a review August 31, 2024 17:32
Copy link
Contributor

@nathanaelren nathanaelren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent

@maxwellmlin
Copy link
Member Author

@vedarshshah https://github.com/DukeRobotics/robosub-ros/actions/runs/10648366606/job/29517336960?pr=555

Actions seems to be failing because of record_bag. Can you fix?

Copy link
Contributor

@viethungle-vt1401 viethungle-vt1401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's Gamble, Try Merging

@viethungle-vt1401 viethungle-vt1401 merged commit c41ca35 into master Sep 7, 2024
16 checks passed
@viethungle-vt1401 viethungle-vt1401 deleted the comp-2024-refactor branch September 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants