-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sensors Status Panel #480
Merged
Merged
Sensors Status Panel #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l' into sensors-status-panel
Co-authored-by: Mathew Chu <[email protected]> Co-authored-by: RaulGalvez288 <[email protected]>
vedarshshah
requested changes
Nov 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to update System Status Panel based on the changes introduced in this PR (theme, version number, package name, etc).
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx
Outdated
Show resolved
Hide resolved
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx
Outdated
Show resolved
Hide resolved
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx
Outdated
Show resolved
Hide resolved
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx
Outdated
Show resolved
Hide resolved
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx
Outdated
Show resolved
Hide resolved
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx
Outdated
Show resolved
Hide resolved
foxglove/extensions/sensors-status-panel/src/SensorsStatusPanel.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathew Chu <[email protected]>
vedarshshah
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #450.
Additionally, the following changes were implemented:
foxglove/theme
directory which contains a custom MUI theme which should be adopted by all future extensions.foxglove.py
compiles this theme intonode_modules
so that the theme can be imported in other packages../foxglove.py
script: You can now use./foxglove.py i
instead of./foxglove.py install
. Additionally, there is a dedicated build command if the user only wishes to build dependencies.