Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logout url claim to session storage #1759

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

Erwinvandervalk
Copy link
Contributor

@Erwinvandervalk Erwinvandervalk commented Feb 5, 2025

What issue does this PR address?
This PR adds the logout claim to the server side session. With this logout claim, you can now render the logout link everywhere in the same way (server rendering, wasm rendering, interactive mode)

To make it easier to do this rendering in wasm, The constants.claimtypes has also been (partially) copied to the blazor.client code.

fixes: #1696

Important: Any code or remarks in your Pull Request are under the following terms:

If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.

(see our license, section 7)

@Erwinvandervalk Erwinvandervalk added area/bff Related to all BFF impact/non-breaking The fix or change is not a breaking one labels Feb 5, 2025
@Erwinvandervalk Erwinvandervalk self-assigned this Feb 5, 2025
@Erwinvandervalk Erwinvandervalk force-pushed the ev/bff/logout-url-claim branch 10 times, most recently from 094e2c7 to e475a60 Compare February 5, 2025 12:34
@Erwinvandervalk Erwinvandervalk force-pushed the ev/bff/logout-url-claim branch from e475a60 to 46aef08 Compare February 5, 2025 13:20
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you decide what to do about the other management claims?

@Erwinvandervalk Erwinvandervalk merged commit 8669493 into main Feb 6, 2025
14 checks passed
@Erwinvandervalk Erwinvandervalk deleted the ev/bff/logout-url-claim branch February 6, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bff Related to all BFF impact/non-breaking The fix or change is not a breaking one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor access to management claims
2 participants