Add a build target for convenient creation of local nuget packages #47
+64
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damianh
reviewed
Nov 17, 2024
Directory.Build.targets
Outdated
Comment on lines
1
to
10
| <Project> | ||
| <PropertyGroup> | ||
| <DuendePackageDir Condition=" '$(DuendePackageDir)' == '' ">$(MSBuildThisFileDirectory)packages</DuendePackageDir> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="PackAndMove" Condition="'$(IsPackable)' == 'true'"> | ||
| <Exec Command="dotnet pack --configuration Release --output $(DuendePackageDir)" /> | ||
| </Target> | ||
|
|
||
| </Project> |
There was a problem hiding this comment.
dotnet pack -o <OutputDir>, dotnet pack -o $env:PACKAGES_PATH at solution level should be sufficient I'd say so don't think we need a custom build target.
damianh
reviewed
Nov 17, 2024
| @@ -0,0 +1,52 @@ | |||
| # Building Packages Locally | |||
There was a problem hiding this comment.
If Directory.Build.targets is removed, can remove this.
Was just thinking if we even need to mention how to build in the readme... it's all standard dotnet CLI after all.
damianh
requested changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a PackAndMove target that packages our libraries locally and moves them to a shared location. This is much more convenient than dealing with a whole bunch of nested subdirectories like
\identity-model\src\IdentityModel\bin\Debug\, both for checking details of the output file and for consuming local builds of packages for testing.Each package can individually be packed and moved, or you can just run the target from the root of the repo and package everything. To ensure that we only package the right things, we respect the property, and there's a bit of cleanup in this PR to make sure IsPackable is set correctly everywhere. There's a new samples.props file to turn it off for sample and client projects.
You can either use the default /packages directory within the repo as the destination, or specify it via environment variable or command line arg.
This PR also creates a docs directory within the foss repo as a home for internal documentation. The first page of that internal doc is a description of this target. I've recently been experimenting with different possible homes for developer docs, and I think I prefer this over anything else, because it co-locates everything - this one PR contains both the new tooling and the documentation for that new tooling.