Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expense update bug #656

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Expense update bug #656

merged 4 commits into from
Dec 30, 2024

Conversation

Macludde
Copy link
Contributor

This PR builds upon the expenses system. It fixes a bug where when updating an expense receipt, the person performing the action would be counted as the signer when calculating the new signer.

This PR also fixes some small issues:

  • Default cost center is no longer AKTU01 but instead null (showing "Välj kostnadsställe")
  • Uploaded images were scaled incorrectly, using "contain" meant black bars. I changed this to "inside" which scales down the image until width and height is both below 1920.

@Macludde Macludde requested a review from trilleplay December 17, 2024 10:32
@Macludde Macludde requested review from alfredgrip and removed request for trilleplay December 18, 2024 13:09
@danieladugyan danieladugyan merged commit 502384b into main Dec 30, 2024
2 checks passed
@danieladugyan danieladugyan deleted the expense-update-bug branch December 30, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants