Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add election editing #650

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Add election editing #650

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1a70185
Use day after expires at
fgren Dec 10, 2024
382f3b6
Add editing to elections
fgren Dec 11, 2024
f842f9e
Remove unused references
fgren Dec 11, 2024
1a5e6e9
Merge branch 'main' into 621-electionsfix2
fgren Dec 11, 2024
f27fa4f
Rename to /elections/create
danieladugyan Dec 15, 2024
7884cb1
Minor general tweaks
danieladugyan Dec 15, 2024
e727dd8
Simplify how initial form data is set
danieladugyan Dec 15, 2024
41063a4
Change edit button to a neutral color
danieladugyan Dec 15, 2024
bcf1c30
Replace custom committee icon code with component
danieladugyan Dec 15, 2024
43e2556
Remove more whitespace and blocking awaits
danieladugyan Dec 15, 2024
2ebf664
Improve component typing
danieladugyan Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/routes/(app)/elections/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@
{#if isAuthorized(apiNames.ELECTION.UPDATE, data.user)}
<a
href={"/elections/" + election.id + "/edit"}
class="btn btn-secondary btn-sm ml-auto">Redigera</a
>
class="btn btn-outline btn-sm ml-auto"
Copy link
Member

@danieladugyan danieladugyan Dec 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of purple (btn-secondary) buttons on the page, but I'm not a big fan of them so I changed this one to a more neutral color.

I'm not really an expert on UI design (clearly... 😄), but colors tend to draw attention and usually signify some kind of main action we want the user to take. Editing is more of an optional action and thus doesn't need to be highlighted.

>Redigera
</a>
{/if}
<img
class="w-5/12 self-center text-center"
Expand Down