Refactor "has active mandate" to reduce db stress #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+116
to
+125
| prisma.mandate.findFirst({ | ||
| where: { | ||
| startDate: { lte: now }, | ||
| endDate: { gte: now }, | ||
| memberId: locals.user?.memberId, | ||
| }, | ||
| select: { | ||
| id: true, | ||
| }, | ||
| }) !== null; |
There was a problem hiding this comment.
@alfredgrip Is this really correct? It looks to me like we're checking if promise !== null, since we're not awaiting the promise here but rather with Promise.allSettled.
There was a problem hiding this comment.
Great catch! Fixed in #536
alfredgrip
added a commit
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks show improvements by 5% 😎
While it's technically faster, it's not too much which is depressing since I thought this would be substantially faster. I guess the overhead from Prisma is what actually is costly, while the query is basically negligible. But still, I think this is good practice