Send notifications to KM when new booking requests are made + new booking review page #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sharedActions.ts
…notification-to-km-when-new-bookings-are-created
…notification-to-km-when-new-bookings-are-created
* Added review mode and functionality to BookingEditor.svelte * Removed old BookingInspector.svelte * Renamed instances of "inspect" to "review" * Added translations message for admin/[id] page title * Moved StatusComponent.svelte to reflect its new usage
…w-bookings-are-created
2 tasks
|
Sorry for the slow review, I just want to do quick demo for @philip-nielsen before we merge! |
|
Looks good |
…-to-km-when-new-bookings-are-created
| mandates: { | ||
| some: { | ||
| positionId: "dsek.km.mastare", | ||
| endDate: { |
There was a problem hiding this comment.
Add a filter for the start date as well! Otherwise we might send notifications to the wrong "Källarmästare", i.e one that has been elected but not yet started their mandate term.
| id: bookingRequest.bookerId ?? undefined, | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
In the rare case where this could actually fail, I still think we should send a notification to the KM.
danieladugyan
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented #487.
Booking request notifications:
Which lead to the new booking review page:
