Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue of TimetableGrid is off by one hour #1240

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fix the issue of TimetableGrid is off by one hour #1240

merged 1 commit into from
Sep 16, 2023
+10 −1

Conversation

aqua-ix
Copy link
Contributor

@aqua-ix aqua-ix commented Sep 16, 2023 •
edited
Loading

Issue

Overview (Required)

  • In order to fix the issue where TimetableGlid was off by one hour, fixed the base time for TimeTableGlid calculation to 10:00 JST.

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before After

@github-actions
Copy link

Test Results

215 tests   215 ✔️  8m 49s ⏱️
  11 suites      0 💤
  11 files        0 ❌

Results for commit fa51f28.

@github-actions github-actions bot temporarily deployed to deploygate-distribution September 16, 2023 01:58 Inactive
@aqua-ix aqua-ix marked this pull request as ready for review September 16, 2023 01:58
@aqua-ix aqua-ix requested a review from a team as a code owner September 16, 2023 01:58
takahirom
takahirom approved these changes Sep 16, 2023
View reviewed changes
Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, it would be better to have the start time set dynamically. But it looks great!

@takahirom takahirom merged commit 968cb40 into DroidKaigi:main Sep 16, 2023
8 checks passed
@aqua-ix aqua-ix deleted the fix-off-by-one-hour branch September 18, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Time Display on TimetableGrid is Off by One Hour
2 participants
@aqua-ix @takahirom