Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bottom sheet behavior request force update #545

Merged
merged 2 commits into from
Jan 23, 2020
Merged

bottom sheet behavior request force update #545

merged 2 commits into from
Jan 23, 2020

Conversation

hirotakaakita
Copy link
Contributor

Issue

Overview (Required)

  • Even if peekHeight was changed, the height of BottomSheetBehavior was not recalculated, so it was recalculated.
  • requestLayout() uses onLayoutChild() because the phenomenon was not resolved.
  • To save computational resources, STATE_COLLAPSED has been added to work only for issues

Links

Screenshot

Before After

@hirotakaakita hirotakaakita requested review from e10dokup and removed request for e10dokup January 22, 2020 17:02
takahirom
takahirom reviewed Jan 22, 2020
View reviewed changes
feature/session/src/main/java/io/github/droidkaigi/confsched2020/session/ui/SessionsFragment.kt
@@ -113,6 +113,12 @@ class SessionsFragment : DaggerFragment() {
binding.sessionsSheet.doOnApplyWindowInsets { _, insets, _ ->
sessionSheetBehavior.peekHeight =
insets.systemWindowInsetBottom + initialPeekHeight + gestureNavigationBottomSpace
if (sessionSheetBehavior.state == BottomSheetBehavior.STATE_COLLAPSED)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍
Can you add a comment? about this workaround 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added 👍

@takahirom
Copy link
Member

LGTM🙏

@jmatsu-bot
Copy link
Collaborator

Your apk has been deployed to https://deploygate.com/distributions/bf4bef2575c4b0fa48a9f1d3c130b7bc088b4e0e. Anyone can try your changes via the link.

Generated by 🚫 Danger

@takahirom takahirom merged commit a78f309 into DroidKaigi:master Jan 23, 2020
@hirotakaakita hirotakaakita deleted the fix/empty_middle_bottom_sheet branch January 23, 2020 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahirom takahirom takahirom left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The front layer of the backdrop (session list) becomes empty and stays in the middle of the screen
3 participants
@hirotakaakita @takahirom @jmatsu-bot