Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Refactoring #38

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[WIP] Refactoring #38

wants to merge 11 commits into from

Conversation

numa08
Copy link

@numa08 numa08 commented Feb 10, 2019

DroidKaigi で得てきた知見を活かしてリファクタリングに挑戦してみました。

  • API レスポンスとドメインオブジェクトを分離した。ドメインオブジェクトを UI に表示させる想定
  • Repository を使って API との通信を抽象化。キャッシュを入れたら Room とのやりとりもやらせる想定
  • Coroutine を使って非同期処理を簡略化

1日使って Repository の実装で力尽きたので、続きは別の機会で。終わったらブログとかに書きます。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant