Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve optimizer settings, live metadata and fix position size calculation #2180

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

techfreaque
Copy link
Contributor

@techfreaque techfreaque commented Jan 11, 2023

requires Drakkar-Software/OctoBot-Trading#797 for the single_contract_value position attribute

as discussed.
regarding your question:

  • why those changes in optimizer settings ?
    If one of the input settings is an empty string, it will set it to default values now

@techfreaque techfreaque force-pushed the master branch 2 times, most recently from adfafcb to 998b57f Compare January 14, 2023 18:01
@techfreaque techfreaque force-pushed the master branch 3 times, most recently from d77c3cd to c828839 Compare January 24, 2023 11:19
@GuillaumeDSM
Copy link
Member

Note: requires octobot_trading position udpated attributes

@techfreaque techfreaque force-pushed the master branch 2 times, most recently from 3e0eca6 to 51e70d1 Compare January 29, 2023 14:40
@techfreaque techfreaque force-pushed the master branch 2 times, most recently from b3854da to f396979 Compare February 10, 2023 18:11
@techfreaque techfreaque force-pushed the master branch 2 times, most recently from 9d567e1 to 7347361 Compare February 16, 2023 16:11
@techfreaque techfreaque force-pushed the master branch 3 times, most recently from a2d5f0e to 7dbf26e Compare March 3, 2023 09:47
Copy link

@ruidazeng ruidazeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants