adds --ladderversion flag, which runs game on version 4.10 #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that some imports are renamed in latest python-sc2, namely kill_switch = KillSwitch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on python-sc2 merge: BurnySc2/python-sc2#213
As discussed, sometime in SC2 version 5.0.x, the map becomes unclickable and you can't issue unit commands.
To allow users to launch on v4.10 (which is the ladder version) this code adds the boolean switch
--ladderversion.It brings back the ability to navigate the minimap and issue commands while your bot is busy.
Note, I had to change some imports which were renamed on latest
python-sc2.The module
kill_switchis nowKillSwitch.Tested against latest python-sc2 at the commit mentioned in the above PR.
If that gets merged, this can be merged. Works for bot-vs-ai and bot-vs-bot.