Chart: add pdb parameter #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffis
requested changes
May 21, 2024
chart/k8s-pause/values.yaml
Outdated
Comment on lines
95
to
97
| # pdb: | ||
| # enabled: true | ||
| # minAvailable: 1 |
There was a problem hiding this comment.
This should not be commented, rather just set pdb.enabled to false.
raffis
approved these changes
May 21, 2024
|
Actually you have to bump the chart version 🙏🏻 |
|
Thanks for your fast review ! Applied & squashed |
|
Oh yes, indeed ! On it |
Signed-off-by: Thibault Gérondal <[email protected]>
|
Thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
I am unable to create a PodDisruptionBudget (PDB), and when the k8s-pause service is down, the mutatingwebhookconfiguration fails. This failure prevents my cluster from creating new pods.
Proposal
Being able to have a PodDisruptionBudget (PDB) should help me with this issue.