digital signing extending #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto signing and verification is very fragile, docs around this should be very precise
pawel-kow
requested changes
Apr 5, 2024
| @@ -720,7 +733,8 @@ key=_dcpubkeyv1 | |||
|
|
|||
| This example indicates that the public key can be found by doing a DNS | |||
| query for a TXT record called _dcpubkeyv1 in the domain specified in the | |||
| syncPubKeyDomain from the template. | |||
| syncPubKeyDomain from the template. | |||
| After generating and adding your key can test if its available from DNS TXT records https://exampleservice.domainconnect.org/sig[here] | |||
There was a problem hiding this comment.
I would rather avoid such references. If necessary we may need an implementation guide, however Getting Started on domainconnect.org worked pretty well so far.
| ---- | ||
| A service for generating the DNS records from your public key can be found https://exampleservice.domainconnect.org/sig[here] |
There was a problem hiding this comment.
Same here. I would rather avoid such references. If necessary we may need an implementation guide, however Getting Started on domainconnect.org worked pretty well so far.
| @@ -709,6 +709,19 @@ EQ%3D%3D | |||
| The Service Provider generates this signature using a private key. As indicated, | |||
| this signature is generated from the query string properly URL encoded. | |||
|
|
|||
| The Service Provider must generate the signature with RSA256 hash, | |||
| PKCS1v15 padding and Base64 encode it before adding it to query parameters. | |||
| Example service in python can be found https://github.com/Domain-Connect/exampleservice/blob/master/sigutil.py[here] | |||
There was a problem hiding this comment.
In the formal specification I would rather not refer to any example implementation or source code other than an example code snippet.
|
Side comment -> more remark to the signing part not being described that well: #93 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto signing and verification is very fragile, docs around this should be very precise