Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve ember-try scenario failures #62

Merged
merged 3 commits into from
Jan 25, 2022
Merged

Resolve ember-try scenario failures #62

merged 3 commits into from
Jan 25, 2022

Conversation

jleja
Copy link
Contributor

@jleja jleja commented Jan 25, 2022 •
edited
Loading

Closes #61.

Changes proposed in this pull request

  • Updates ember-default-with-jquery to use feature:enable jquery-integrations in the test command.
  • Allows Embroider scenarios to fail. Fixing scenarios might be able to be handled with Incompatibility with Embroider #46.

@jleja jleja self-assigned this Jan 25, 2022
mehulkar
mehulkar reviewed Jan 25, 2022
View reviewed changes
config/ember-try.js Outdated Show resolved Hide resolved
@mehulkar
Copy link

nice. 🚢 ?

@jleja jleja merged commit dc3b4eb into master Jan 25, 2022
@jleja jleja deleted the jleja/disable-embrodier-scenarios branch January 25, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehulkar mehulkar mehulkar left review comments

Assignees

@jleja jleja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test scenarios
2 participants
@jleja @mehulkar