Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#42 Fix get quote with invalid token #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VictorKadup
Copy link

With this change we wont get an wrong response by making requests with an unknown cart token

@sandermangel
Copy link

Hi Victor, thanks for your PR. Mind going into a bit more details on how this prevents that?

Copy link
Collaborator

@nhp nhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return of that function is already checked for true/false within validateQuote() and that looks correct according to the implicit return types of the currentQuote()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants