Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback for shiny-intro.Rmd #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feedback for shiny-intro.Rmd #28

wants to merge 1 commit into from

Conversation

howardbaik
Copy link
Contributor

  1. Figure 10.1- Much easier to read since the fonts are bigger.

  2. Section 10.2.1 What is a websocket?

  • It was a bit confusing to understand...maybe some diagrams would help the reader understand the mechanics.
  1. Overall, more figures / diagrams like Figure 5 would help this chapter because this chapter is fairly technical and I think more illustrations and diagrams are needed to support the text explanation.

@howardbaik
Update shiny-intro.Rmd
832596b 
1. Figure 10.1- Much easier to read since the fonts are bigger.

2. Section 10.2.1 What is a websocket? 
- It was a bit confusing to understand...maybe some diagrams would help the reader understand the mechanics.

3. Overall, more figures / diagrams like Figure 5 would help this chapter because this chapter is fairly technical and I think more illustrations and diagrams are needed to support the text explanation.
@DivadNojnarg
Copy link
Owner

Do you think this chapter was useful?

@DivadNojnarg
Copy link
Owner

I significantly reworked the chapter. I added a fun example consisting in creating a R plot from JS via the websocket (without shiny) and update a gauge JS widget from R. Let me know what you think. https://unleash-shiny.rinterface.com/shiny-intro.html#shiny-websocket

@howardbaik
Copy link
Contributor Author

I think this chapter got significantly better! More visuals made the reading easier. Also, the figures with code are now large enough to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howardbaik @DivadNojnarg